Re: [PATCH v4 14/17] bootconfig: add __packed definition to tools/bootconfig shim header

[Google]

On Sat, 14 Mar 2026 23:01:52 +0000
Josh Law <objecting@xxxxxxxxxxxxx> wrote:

> The tools/bootconfig userspace build includes the main bootconfig.h
> via a shim header that defines kernel macros for userspace. Add the
> __packed macro so the struct xbc_node declaration works after the
> conversion from open-coded __attribute__((__packed__)).
> 

NACK. Please do not self recover after break something by yourself
in the same series.

> Signed-off-by: Josh Law <objecting@xxxxxxxxxxxxx>
> ---
>  tools/bootconfig/include/linux/bootconfig.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/bootconfig/include/linux/bootconfig.h b/tools/bootconfig/include/linux/bootconfig.h
> index 6784296a0692..41c50ab95ba5 100644
> --- a/tools/bootconfig/include/linux/bootconfig.h
> +++ b/tools/bootconfig/include/linux/bootconfig.h
> @@ -48,6 +48,7 @@ static inline char *strim(char *s)
>  
>  #define __init
>  #define __initdata
> +#define __packed	__attribute__((__packed__))
>  
>  #include "../../../../include/linux/bootconfig.h"
>  
> -- 
> 2.34.1
> 
> 


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>