Re: [PATCH] mfd/ASoC: WM8400: select SND_SOC_WM8400 from MFD_WM8400
From: Mark Brown
Date: Sun Mar 15 2026 - 19:56:14 EST
On Mon, Mar 16, 2026 at 01:51:17AM +0530, Piyush Patle wrote:
> The MFD driver wm8400-core.c unconditionally registers a platform
> device named 'wm8400-codec' via wm8400_register_codec(). The codec
> driver in sound/soc/codecs/wm8400.c binds to this device by name,
> but SND_SOC_WM8400 is a hidden symbol with no prompt and nothing
> was selecting it in normal configurations, so the driver never built.
>
> Fix this by adding 'select SND_SOC_WM8400' to MFD_WM8400, which
> encodes the implicit dependency that already existed at runtime.
> Also remove the FIXME comment that noted this gap.
This doesn't accomplish anything, the driver will do nothing unless a
sound card binds to it. This is very standard for older CODEC drivers,
the comment just shouldn't be there.
Attachment:
signature.asc
Description: PGP signature