Re: [PATCH v7 13/13] PCI: tegra194: Free resources during controller deinitialization

[Manivannan Sadhasivam]

On Sun, Mar 15, 2026 at 07:46:49PM +0530, Manikanta Maddireddy wrote:
> 
> 
> On 05/03/26 4:13 pm, Manivannan Sadhasivam wrote:
> > On Tue, Mar 03, 2026 at 12:24:48PM +0530, Manikanta Maddireddy wrote:
> > > From: Vidya Sagar <vidyas@xxxxxxxxxx>
> > > 
> > > Call pci_epc_deinit_notify() during controller deinitialization to free the
> > > resources allocated by Endpoint function driver. This is safe to call
> > > during PCIe assert sequence because we don't expect Endpoint function
> > > driver to touch hardware in deinit function.
> > > 
> > 
> > Are you sure? The epf-test driver itself touches DBI space during deinit.
> > 
> > - Mani
> Ok, I see epf-test is doing clear_bar which access DBI space.
> But, I think we should give give a chance to EPF drivers to clean up
> resources and stop using them in PERST# assert. Let me know your inputs on
> this.
> 

You cannot control the EPF behavior from the controller driver. So I'd prefer
not changing the flow.

- Mani

-- 
மணிவண்ணன் சதாசிவம்