Re: [PATCH net-next v01 5/7] hinic3: Add MTU size validation

[Fan Gong]

On 3/13/2026 4:50 PM, Maxime Chevallier wrote:
> Hi,
>
> On 13/03/2026 08:54, Fan Gong wrote:
>>   Check whether the MTU size is within a reasonable range.
>
> I don't get why this is needed when we have netdev->min_mtu and
> netdev->max_mtu already to sanitize these parameters.
>
> Is this patch needed, and if so can you explain why the
> netdev->min/max_mtu parameters aren't enough ?
>
> Maxime
>

Thanks for your two reviews. We overlooked redundant defensive code and
pointer release operation in patch 2/7.
We will fix them in next version.

Fan gong