Re: [PATCH v3 7/7] leds: add synology microp led driver

From: Greg Kroah-Hartman

Date: Mon Mar 16 2026 - 02:35:19 EST


On Sun, Mar 15, 2026 at 08:41:06PM +0100, Danilo Krummrich wrote:
> I.e. if we can't (easily) use mfd cells and would need a custom API, then why
> even split it up at all, given that splitting it up would probably the most
> complicated part of the whole driver.
>
> Greg, what do you think?

I think this has yet to be proven to be a kernel driver at all at this
point, and not just a userspace daemon that listens to the serial port
and then does what is needed from there :)

Or, if someone can prove that the operations on this serial data stream
actually do require it to be in the kernel (which I have yet to see a
list of what this connection does, did I miss it?) then a single driver,
under the drivers/platform section of the kernel tree makes sense.

thanks,

greg k-h