Re: [PATCH] net: dsa: bcm_sf2: fix missing clk_disable_unprepare() in error paths

[Jonas Gorski]

On Sat, Mar 14, 2026 at 9:11 AM Anas Iqbal <mohd.abd.6602@xxxxxxxxx> wrote:
>
> Smatch reports:
> drivers/net/dsa/bcm_sf2.c:997 bcm_sf2_sw_resume() warn:
> 'priv->clk' from clk_prepare_enable() not released on lines: 983,990.
>
> The clock enabled by clk_prepare_enable() in bcm_sf2_sw_resume()
> is not released if bcm_sf2_sw_rst() or bcm_sf2_cfp_resume() fails.
>
> Add the missing clk_disable_unprepare() calls in the error paths
> to properly release the clock resource.
>
> Signed-off-by: Anas Iqbal <mohd.abd.6602@xxxxxxxxx>

It's a fix, so it should have Fixes tag, e.g.

Fixes: e9ec5c3bd238 ("net: dsa: bcm_sf2: request and handle clocks")

apart from that

Reviewed-by: Jonas Gorski <jonas.gorski@xxxxxxxxx>