Re: [PATCH v2 0/2] regulator: fp9931: Make vin-supply mandatory

[Robby Cai]

On Fri, Mar 13, 2026 at 04:27:21PM +0000, Mark Brown wrote:
> On Fri, Mar 13, 2026 at 01:31:23PM +0000, Mark Brown wrote:
> > On Fri, Mar 13, 2026 at 09:31:00PM +0800, Robby Cai wrote:
> > > The FP9931 regulator requires a valid "vin" supply to operate correctly.
> > > Therefore, the driver should treat "vin" as a mandatory supply.
> 
> > > This patchset updates the binding documentation to mark vin-supply as a
> > > required property, and modifies the driver accordingly. As suggested in
> > > the reviews from Andreas and Mark, v2 switches to using
> > > devm_regulator_get() since the supply is mandatory.
> 
> > Please do not submit new versions of already applied patches, please
> > submit incremental updates to the existing code.  Modifying existing
> > commits creates problems for other users building on top of those
> > commits so it's best practice to only change pubished git commits if
> > absolutely essential.
> 
> Your v1 was at the tip of the branch so I did actually just drop it, but
> please don't do this.

Thanks for the clarification.

Just to confirm: since you already dropped the v1 from your tree,
does that mean I should wait and only send an incremental patch
when there is a further change needed?

Regards,
Robby