RE: [Intel-wired-lan] [PATCH net-next v9 6/7] vmxnet3: Implement ndo_set_rx_mode_async callback
From: Loktionov, Aleksandr
Date: Mon Mar 16 2026 - 03:37:43 EST
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf
> Of I Viswanath
> Sent: Saturday, March 14, 2026 7:28 PM
> To: stfomichev@xxxxxxxxx; horms@xxxxxxxxxx; edumazet@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; andrew+netdev@xxxxxxx; kuba@xxxxxxxxxx;
> davem@xxxxxxxxxxxxx; eperezma@xxxxxxxxxx; xuanzhuo@xxxxxxxxxxxxxxxxx;
> jasowang@xxxxxxxxxx; mst@xxxxxxxxxx; Kitszel, Przemyslaw
> <przemyslaw.kitszel@xxxxxxxxx>; Nguyen, Anthony L
> <anthony.l.nguyen@xxxxxxxxx>; Keller, Jacob E
> <jacob.e.keller@xxxxxxxxx>; ronak.doshi@xxxxxxxxxxxx;
> pcnet32@xxxxxxxxxxxx
> Cc: bcm-kernel-feedback-list@xxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> virtualization@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; I Viswanath
> <viswanathiyyappan@xxxxxxxxx>
> Subject: [Intel-wired-lan] [PATCH net-next v9 6/7] vmxnet3: Implement
> ndo_set_rx_mode_async callback
>
> Implement the ndo_set_rx_mode_async callback and update the driver to
> use the snapshot/commit model for RX mode update.
>
> Signed-off-by: I Viswanath <viswanathiyyappan@xxxxxxxxx>
> ---
>
> Call paths involving netif_set_rx_mode in vmxnet3
>
> netif_set_rx_mode
> `-- vmxnet3_activate_dev
> |-- vmxnet3_open (ndo_open, takes lock)
> |-- vmxnet3_change_mtu (ndo_change_mtu, takes lock)
> |-- vmxnet3_reset_work (takes lock)
> |-- vmxnet3_resume (lock added)
> |-- vmxnet3_set_ringparam (ethtool callback, takes lock)
> `-- vmxnet3_xdp_set
> `-- vmxnet3_xdp (ndo_bpf, takes lock)
>
> drivers/net/vmxnet3/vmxnet3_drv.c | 46 +++++++++++++++++++++++-------
> -
> 1 file changed, 35 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c
> b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 40522afc0532..350e44286c00 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -2775,18 +2775,18 @@ static u8 *
> vmxnet3_copy_mc(struct net_device *netdev) {
> u8 *buf = NULL;
...
> err);
> --
> 2.47.3
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>