Re: [PATCH 2/3] netfilter: add missing kernel-doc parameters for nf_hook()
From: Florian Westphal
Date: Mon Mar 16 2026 - 04:01:49 EST
Kit Dallege <xaum.io@xxxxxxxxx> wrote:
> /**
> * nf_hook - call a netfilter hook
> + * @pf: protocol family (e.g. NFPROTO_IPV4)
> + * @hook: hook number (e.g. NF_INET_PRE_ROUTING)
> + * @net: network namespace
> + * @sk: socket associated with the packet, or NULL
> + * @skb: socket buffer holding the packet
> + * @indev: input network device, or NULL
> + * @outdev: output network device, or NULL
> + * @okfn: function to call if the hook allows the packet to pass
> *
I tend towards not applying this, I don't think this adds any value,
the arguments are rather obvious for anyone doing kernel networking
and its not a utility/library function either.