Re: [PATCH] staging/media/av7110: update FIXME comment for signal strength

[Dan Carpenter]

On Thu, Mar 12, 2026 at 07:21:17PM +0100, Tomasz Unger wrote:
> Update the FIXME comment to provide more detail about the future
> implementation for computing the signal strength based on the tuner RSSI.
> 
> Signed-off-by: Tomasz Unger <tomasz.unger@xxxxxxxx>
> ---
>  drivers/staging/media/av7110/av7110_v4l.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/av7110/av7110_v4l.c b/drivers/staging/media/av7110/av7110_v4l.c
> index 200a7a29ea31..a64761979609 100644
> --- a/drivers/staging/media/av7110/av7110_v4l.c
> +++ b/drivers/staging/media/av7110/av7110_v4l.c
> @@ -310,7 +310,7 @@ static int vidioc_g_tuner(struct file *file, void *fh, struct v4l2_tuner *t)
>  		V4L2_TUNER_CAP_LANG1 | V4L2_TUNER_CAP_LANG2 | V4L2_TUNER_CAP_SAP;
>  	t->rangelow = 772;	/* 48.25 MHZ / 62.5 kHz = 772, see fi1216mk2-specs, page 2 */
>  	t->rangehigh = 13684;	/* 855.25 MHz / 62.5 kHz = 13684 */
> -	/* FIXME: add the real signal strength here */
> +	/* TODO: compute based on tuner RSSI */

This seems reasonable and also pointless.  Is this AI?

regards,
dan carpenter

>  	t->signal = 0xffff;
>  	t->afc = 0;
>  
> 
> ---