Re: [PATCH v3 1/2] dt-bindings: display: panel: Add Himax HX83121A
From: Krzysztof Kozlowski
Date: Mon Mar 16 2026 - 04:15:35 EST
On 16/03/2026 09:02, Pengyu Luo wrote:
> On Mon, Mar 16, 2026 at 3:44 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>
>> On Sun, Mar 15, 2026 at 10:45:35PM +0800, Pengyu Luo wrote:
>>> HX83121A is a driver IC used to drive MIPI-DSI panels. It is found
>>> in HUAWEI Matebook E Go series (Gaokun2/3) with BOE or CSOT panels.
>>>
>>> Signed-off-by: Pengyu Luo <mitltlatltl@xxxxxxxxx>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>>> ---
>>> v3:
>>> - remove '|' from description (Krzysztof)
>>> - drop description for reset-gpios (Krzysztof)
>>
>> And all other changes?
>>
>> Why aren't you testing this code?
>>
>> NAK, drop the tag and request re-review.
>>
>
> I see. I will send a new version later. I made changes to v1 binding by mistake.
And EVERY patch you sent must be build tested, which would tell you that
you made mistakes. Why do you think build testing your code is our task?
Best regards,
Krzysztof