Re: [PATCH 2/5] irqchip: Add Qualcomm MSM VIC driver

[Krzysztof Kozlowski]

On 15/03/2026 12:17, j0sh1x wrote:
> Signed-off-by: j0sh1x <aljoshua.hell@xxxxxxxxx>

You must use full name.

> ---
>  drivers/irqchip/irq-msm-vic.c | 361 ++++++++++++++++++++++++++++++++++
>  1 file changed, 361 insertions(+)
>  create mode 100644 drivers/irqchip/irq-msm-vic.c
> 
> diff --git a/drivers/irqchip/irq-msm-vic.c b/drivers/irqchip/irq-msm-vic.c
> new file mode 100644
> index 000000000000..7e7f7be3ad6d
> --- /dev/null
> +++ b/drivers/irqchip/irq-msm-vic.c
> @@ -0,0 +1,361 @@
> +// SPDX-License-Identifier: GPL-2.0 OR MIT
> +/*
> + * Copyright (C) 2007 Google, Inc.
> + * Copyright (c) 2009, Code Aurora Forum. All rights reserved.
> + * Copyright (c) 2024, Htc Leo Revival Project
> + *
> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.

We don't take 19 years old code. You need to fix it to match current
Linux kernel style, which means most likely all this has to be
completely rewritten from scratch. Take latest reviewed drivers as
starting point, not something from 2007.

Best regards,
Krzysztof