Re: [PATCH] staging: rtl8723bs: rename 'status' variable to 'ret' for consistency
From: Dan Carpenter
Date: Mon Mar 16 2026 - 04:39:40 EST
On Sat, Mar 14, 2026 at 05:56:00PM +0100, Omer El Idrissi wrote:
> The kernel commonly uses 'ret', 'retval', 'err' etc. for return value
> tracking. No functional change intended beyond style and error handling
> improvement.
>
> Signed-off-by: Omer El Idrissi <omer.e.idrissi@xxxxxxxxx>
> ---
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index d664e254912c..dbcde683789d 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -345,7 +345,7 @@ static int rtw_drv_init(
> struct sdio_func *func,
> const struct sdio_device_id *id)
> {
> - int status = _FAIL;
> + int ret = _FAIL;
status is actually better because these are non-standard error codes.
First fix that, then rename the variables to ret.
regards,
dan carpenter