Re: [PATCH] mtd: rawnand: pl353: make sure optimal timings are applied
From: Miquel Raynal
Date: Mon Mar 16 2026 - 04:46:59 EST
Hello Olivier,
+ Andrea
On 04/03/2026 at 22:18:23 +01, Olivier Sobrie <olivier@xxxxxxxxx> wrote:
> Timings of the nand are adjusted by pl35x_nfc_setup_interface() but
> actually applied by the pl35x_nand_select_target() function.
> If there is only one nand chip, the pl35x_nand_select_target() will only
> apply the timings once since the test at its beginning will always be true
> after the first call to this function. As a result, the hardware will
> keep using the default timings set at boot to detect the nand chip, not
> the optimal ones.
>
> With this patch, we program directly the new timings when
> pl35x_nfc_setup_interface() is called.
>
> Signed-off-by: Olivier Sobrie <olivier@xxxxxxxxx>
Nice, this probably will deserve a Fixes tag and Cc: stable.
Andrea, this might be the reason why your NAND chip misbehaves after a
set_feature. Would you mind testing it?
Thanks,
Miquèl