Re: [PATCH] i3c: master: dw-i3c: Assert reset control in remove() callback

[Philipp Zabel]

On Mo, 2026-03-16 at 21:55 +0800, Felix Gu wrote:
> The reset line acquired during probe is currently left unasserted
> when the driver is unbound. Add the missing reset_control_assert()
> call to properly reset the hardware when the driver is unbound.
> 
> Fixes: 62fe9d06f570 ("i3c: dw: Add power management support")
> Signed-off-by: Felix Gu <ustc.gu@xxxxxxxxx>
> ---
>  drivers/i3c/master/dw-i3c-master.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index d87bde3f7700..5303282eb816 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1690,6 +1690,8 @@ void dw_i3c_common_remove(struct dw_i3c_master *master)
>  	pm_runtime_disable(master->dev);
>  	pm_runtime_set_suspended(master->dev);
>  	pm_runtime_dont_use_autosuspend(master->dev);
> +
> +	reset_control_assert(master->core_rst);

Switching to devm_reset_control_get_optional_exclusive_deasserted() and
removing the reset_control_deassert() in dw_i3c_common_probe() would
have the same effect.

regards
Philipp