Re: [PATCH v2 2/3] gpio: timberdale: use device properties

From: Andy Shevchenko

Date: Mon Mar 16 2026 - 11:14:15 EST


On Mon, Mar 16, 2026 at 10:30:49AM +0100, Bartosz Golaszewski wrote:
> The top-level MFD driver now passes the device properties to the GPIO
> cell via the software node. Use generic device property accessors and
> stop using platform data. We can ignore the "ngpios" property here now
> as it will be retrieved internally by GPIO core.

...

> int irq = platform_get_irq(pdev, 0);


> gc->to_irq = (irq >= 0 && tgpio->irq_base > 0) ? timbgpio_to_irq : NULL;

> if (irq < 0 || tgpio->irq_base <= 0)
> return 0;

I believe we also want to have a fix of the above (it will print a message when
it's fine to continue and checks for irq > 0 twice).

--
With Best Regards,
Andy Shevchenko