Re: [PATCH] nvme-tcp.h: drop kernel-doc comments, fix a few descriptions
From: Christoph Hellwig
Date: Mon Mar 16 2026 - 12:22:36 EST
On Fri, Mar 13, 2026 at 09:04:21PM -0700, Randy Dunlap wrote:
> Expand @fei into @feil and @feih because the field was split due to it
> not being 32-bit aligned.
>
> Struct member @hdr was described twice in struct nvme_tcp_rsp_pdu, so
> drop one of them.
>
> These structs are defined in a spec outside of the kernel, so kernel-doc
> comments for them aren't needed here as well.
>
> This avoids kernel-doc warnings:
I would have just dropped the comment entirely except for a reference
to the spec, but let's get the warning fixed instead of bikeshedding
for now:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>