Re: [PATCH 1/2] regulator: pca9450: Correct interrupt type

[Andy Shevchenko]

On Tue, Mar 10, 2026 at 03:34:35PM +0000, Mark Brown wrote:
> On Tue, Mar 10, 2026 at 01:24:44PM +0000, Peng Fan (OSS) wrote:
> 
> > BTW, I am also thinking whether we need to drop setting
> > IRQF_TIRRGER_[X] when calling request irq in this driver.
> 
> I can't remember off hand what the effect of that is TBH.  I'm not sure
> how it'd interact with incorrectly specified DTs?

One may need a quirk for incorrectly specified DTs,
basically something like

	flags = irq_...get flags...(...);
	if (flags & BAD!)
		...issue warning and fix the flags...

	ret = devm_irq_...(flags)

...

Also consider dropping dup error message as devm_*_irq*() already does that
for us.

-- 
With Best Regards,
Andy Shevchenko