Re: [PATCH] platform/x86: thinkpad-acpi: Add X1 Fold keyboard attachment detection
From: Mark Pearson
Date: Mon Mar 16 2026 - 14:24:44 EST
On Mon, Mar 16, 2026, at 2:06 PM, Pit Henrich wrote:
> On Mon, 16 Mar 2026 at 14:24, Hans de Goede <hansg@xxxxxxxxxx> wrote:
>> Looking at pictures of the Fold 16 gen 1, I assume this sysfs attr will return 1 when the keyboard
>> is clicked on one half of the foldable screen, covering that half so that the laptop resembles
>> a classic clamshell design in this mode. Since this is actually covering half the screen I think
>> that keyboard_attached_on_screen actually is a good name :)
>
> Yes, exactly right :)
>
> The keyboard can also be used when it is not attached, via Bluetooth.
> And there is actually another way that Lenovo intended the keyboard
> to be attached, but that way is not detectable (and wouldn't affect
> any functional behavior anyway).
>
> The intended userspace use case for this sysfs attr is to detect when
> the keyboard is attached on the lower half of the display, so that UI
> elements can be moved up and only the top half of the screen is used.
> It's a very unique use case for sure.
>
Got it - my bad. My (mild) objection is retracted ;)
Mark