Re: [PATCH v2] staging: rtl8723bs: remove unused global efuse variables

[Ethan Tidmore]

On Mon Mar 16, 2026 at 5:04 PM CDT, Marcos Andrade wrote:
> Remove several global efuse variables from rtw_efuse.c and their
> corresponding extern declarations in rtw_efuse.h.
>
> These variables (fakeEfuseBank, BTEfuseUsedBytes, etc.) are completely
> unused legacy code. The driver currently maintains the efuse state
> properly within the 'efuse_hal' structure, which is encapsulated
> inside 'hal_com_data'.
>
> The removal of this dead code cleans up the global namespace and
> resolves multiple checkpatch.pl warnings regarding CamelCase naming
> conventions. Verified by compilation that no functional code references
> these variables.
>
> Signed-off-by: Marcos Andrade <marcosandrade95963@xxxxxxxxx>
> Reviewed-by: Ethan Tidmore <ethantidmore06@xxxxxxxxx>
> ---
> Changes in v2:
>  - Collected Reviewed-by tag from Ethan Tidmore.

You don't have to do this. Normally you only do this would a reivewer
gives you specifc instructions to do and then you can add their RB tag
with their approval.

Thanks,

ET