Re: [PATCH] ASoC: simple-card-utils: Check playback-only and capture-only input value

[Shengjiu Wang]

On Tue, Mar 17, 2026 at 7:29 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
>
>
> Hi Shengjiu
>
> > The audio-graph-card2 gets the value of 'playback-only' and
> > 'capture_only' property in below sequence, if there is 'playback_only' or
> > 'capture_only' property in port_cpu and port_codec nodes, but no these
> > properties in ep_cpu and ep_codec nodes, the value of playback_only and
> > capture_only will be flushed to zero in the end.
> >
> > graph_util_parse_link_direction(lnk,            &playback_only, &capture_only);
> > graph_util_parse_link_direction(ports_cpu,      &playback_only, &capture_only);
> > graph_util_parse_link_direction(ports_codec,    &playback_only, &capture_only);
> > graph_util_parse_link_direction(port_cpu,       &playback_only, &capture_only);
> > graph_util_parse_link_direction(port_codec,     &playback_only, &capture_only);
> > graph_util_parse_link_direction(ep_cpu,         &playback_only, &capture_only);
> > graph_util_parse_link_direction(ep_codec,       &playback_only, &capture_only);
> >
> > So check the input value of playback_only and capture_only in
> > graph_util_parse_link_direction() function, if they are true, then won't
> > rewrite the values.
> >
> > Fixes: 22a507d7680f ("ASoC: simple-card-utils: Check device node before overwrite direction")
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@xxxxxxx>
> > ---
> >  sound/soc/generic/simple-card-utils.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
> > index 3115e1f37c0c..e1564c1f7d8d 100644
> > --- a/sound/soc/generic/simple-card-utils.c
> > +++ b/sound/soc/generic/simple-card-utils.c
> > @@ -1202,9 +1202,9 @@ void graph_util_parse_link_direction(struct device_node *np,
> >       bool is_playback_only = of_property_read_bool(np, "playback-only");
> >       bool is_capture_only  = of_property_read_bool(np, "capture-only");
> >
> > -     if (np && playback_only)
> > +     if (np && playback_only && !(*playback_only))
> >               *playback_only = is_playback_only;
> > -     if (np && capture_only)
> > +     if (np && capture_only && !(*capture_only))
> >               *capture_only = is_capture_only;
> >  }
>
> Hmm... It become complex more and more...
>
> I think it should check "is_playback_only" instead of "playback_only" ?
> Oops, this patch changed the behavior, and it is the reason why you
> got issue many times.
>
>         3cc393d2232ec770b5f79bf0673d67702a3536c3
>         ("ASoC: simple-card-utils: Fix pointer check in graph_util_parse
>          _link_direction")
>
> *playback_only pointer check is indeed needed, but *np pointer check is
> not needed because of_property_read_bool() will ignore if it was NULL.
> So maybe we want to have is
>
>         if (playback_only && is_playback_only)
>             (A)              (B)
>
>         (A) pointer check
>         (B) value   check

Thanks, I will update according to your suggestion.

best regards
shengjiu wang
>
> Thank you for your help !!
>
> Best regards
> ---
> Kuninori Morimoto
>