Re: [PATCH] ALSA: firewire-lib: fix uninitialized local variable
From: Takashi Iwai
Date: Tue Mar 17 2026 - 04:56:59 EST
On Mon, 16 Mar 2026 20:18:22 +0100,
Alexey Nepomnyashih wrote:
>
> Similar to commit d8dc8720468a ("ALSA: firewire-lib: fix uninitialized
> local variable"), the local variable `curr_cycle_time` in
> process_rx_packets() is declared without initialization.
>
> When the tracepoint event is not probed, the variable may appear to be
> used without being initialized. In practice the value is only relevant
> when the tracepoint is enabled, however initializing it avoids potential
> use of an uninitialized value and improves code safety.
>
> Initialize `curr_cycle_time` to zero.
>
> Fixes: fef4e61b0b76 ("ALSA: firewire-lib: extend tracepoints event including CYCLE_TIME of 1394 OHCI")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Alexey Nepomnyashih <sdl@xxxxxxxx>
Applied now. Thanks.
Takashi