Re: [PATCH 1/1] clk: imx: pll14xx: Use unsigned format specifier

[Daniel Baluta]

On 3/17/26 11:33, Alexander Stein wrote:
> The debug outputs use %d for clock rates resulting in negative clock rate
> during rate calculation.
>
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> ---
>  drivers/clk/imx/clk-pll14xx.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c
> index 7552aaafc3395..701a7a02235cc 100644
> --- a/drivers/clk/imx/clk-pll14xx.c
> +++ b/drivers/clk/imx/clk-pll14xx.c
> @@ -151,7 +151,7 @@ static void imx_pll14xx_calc_settings(struct clk_pll14xx *pll, unsigned long rat
>  	/* First try if we can get the desired rate from one of the static entries */
>  	tt = imx_get_pll_settings(pll, rate);
>  	if (tt) {
> -		pr_debug("%s: in=%ld, want=%ld, Using PLL setting from table\n",
> +		pr_debug("%s: in=%lu, want=%lu, Using PLL setting from table\n",
>  			 clk_hw_get_name(&pll->hw), prate, rate);
>  		t->rate = tt->rate;
>  		t->mdiv = tt->mdiv;
> @@ -173,7 +173,7 @@ static void imx_pll14xx_calc_settings(struct clk_pll14xx *pll, unsigned long rat
>  
>  	if (rate >= rate_min && rate <= rate_max) {
>  		kdiv = pll1443x_calc_kdiv(mdiv, pdiv, sdiv, rate, prate);
> -		pr_debug("%s: in=%ld, want=%ld Only adjust kdiv %ld -> %d\n",
> +		pr_debug("%s: in=%lu, want=%lu Only adjust kdiv %ld -> %d\n",
>  			 clk_hw_get_name(&pll->hw), prate, rate,
>  			 FIELD_GET(KDIV_MASK, pll_div_ctl1), kdiv);
>  		fout = pll14xx_calc_rate(pll, mdiv, pdiv, sdiv, kdiv, prate);
> @@ -211,7 +211,7 @@ static void imx_pll14xx_calc_settings(struct clk_pll14xx *pll, unsigned long rat
>  		}
>  	}
>  found:
> -	pr_debug("%s: in=%ld, want=%ld got=%d (pdiv=%d sdiv=%d mdiv=%d kdiv=%d)\n",
> +	pr_debug("%s: in=%ld, want=%lu got=%u (pdiv=%d sdiv=%d mdiv=%d kdiv=%d)\n",

Since you are here, I think this should be 'got = %lu' instead of %u.