Re: [PATCH] device property: Make modifications of fwnode "flags" thread safe
From: Danilo Krummrich
Date: Tue Mar 17 2026 - 06:08:42 EST
On Tue Mar 17, 2026 at 9:42 AM CET, Wolfram Sang wrote:
>
>> > What's the alignment for the u8 member in your SoC? 4 bytes or 8 bytes?
>> > (I assume it's 64-bit SoC.)
>>
>> FWIW, with the given change it will be still inside 64-byte data structure
>> which most likely occupies a single cache line (before this patch and after
>> as well).
>
> I consider this directon of the discussion irrelevant. If the number is
> (maybe? That's to be discussed!) needlessly bigger than 0, then it
> doesn't matter how big the number is.
>
> Why don't you like the idea of taking the lock?
Which lock are we talking about, the device lock? If so, please not use it to
protect arbitrary other structures.