[PATCH AUTOSEL 6.19-6.1] ALSA: hda/realtek: add HP Laptop 14s-dr5xxx mute LED quirk

From: Sasha Levin

Date: Tue Mar 17 2026 - 07:33:51 EST


From: Liucheng Lu <luliucheng100@xxxxxxxxxxx>

[ Upstream commit 178dd118c0f07fd63a9ed74cfbd8c31ae50e33af ]

HP Laptop 14s-dr5xxx with ALC236 codec does not handle the toggling of
the mute LED.
This patch adds a quirk entry for subsystem ID 0x8a1f using
ALC236_FIXUP_HP_MUTE_LED_COEFBIT2 fixup, enabling correct mute LED
behavior.

Signed-off-by: Liucheng Lu <luliucheng100@xxxxxxxxxxx>
Link: https://patch.msgid.link/PAVPR03MB9774F3FCE9CCD181C585281AE37BA@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
---

LLM Generated explanations, may be completely bogus:

## Analysis

This is a textbook audio codec quirk addition — a single `SND_PCI_QUIRK`
line added to the HDA Realtek quirk table for HP Laptop 14s-dr5xxx
(subsystem ID `0x103c:0x8a1f`), using the existing
`ALC236_FIXUP_HP_MUTE_LED_COEFBIT2` fixup.

**What it fixes:** The mute LED on HP Laptop 14s-dr5xxx doesn't toggle
correctly without this quirk. This is a real hardware issue affecting
users of this specific laptop model.

**Scope and risk:** One line added to a quirk table. The fixup
`ALC236_FIXUP_HP_MUTE_LED_COEFBIT2` is already used by multiple other HP
laptops in the same table (e.g., `0x89a0` "HP Laptop 15-dw4xxx",
`0x8a20` "HP Laptop 15s-fq5xxx"). Zero risk of regression — it only
matches the specific subsystem ID and applies an already-proven fixup
chain.

**Stable criteria:**
- Obviously correct: Yes, trivial one-line quirk entry
- Fixes a real bug: Yes, broken mute LED on specific hardware
- Small and contained: Yes, single line
- No new features: Correct, uses existing fixup
- No new APIs: Correct

This falls squarely into the "AUDIO CODEC QUIRKS" exception category
explicitly listed as YES for stable.

Verification:
- Confirmed from the diff that `ALC236_FIXUP_HP_MUTE_LED_COEFBIT2` is
already used by adjacent entries (lines for 0x89a0 and 0x8a20) in the
same quirk table
- Confirmed the change is a single line addition with no other code
modifications
- The commit was accepted by the HDA maintainer (Takashi Iwai) via the
standard patch process

**YES**

sound/hda/codecs/realtek/alc269.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index f5719e630d28a..13d14c86569f9 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6917,6 +6917,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x89da, "HP Spectre x360 14t-ea100", ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),
SND_PCI_QUIRK(0x103c, 0x89e7, "HP Elite x2 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8a1f, "HP Laptop 14s-dr5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
SND_PCI_QUIRK(0x103c, 0x8a20, "HP Laptop 15s-fq5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
SND_PCI_QUIRK(0x103c, 0x8a25, "HP Victus 16-d1xxx (MB 8A25)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
SND_PCI_QUIRK(0x103c, 0x8a26, "HP Victus 16-d1xxx (MB 8A26)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
--
2.51.0