Re: [PATCH] firmware: arm_scmi: extract domain ID validation helpers
From: Artem Shimko
Date: Tue Mar 17 2026 - 08:06:21 EST
On Thu, Jan 22, 2026 at 7:17 PM Artem Shimko <a.shimko.dev@xxxxxxxxx> wrote:
>
> Refactor the voltage protocol implementation by moving repeated domain
> ID boundary checks into dedicated inline functions. This reduces code
> duplication and improves maintainability.
>
> The new helpers are scmi_voltage_domain_validate_id() which validates
> a domain ID and returns an error code, and scmi_voltage_domain_lookup()
> which returns a pointer to the domain structure or an error pointer.
> These are used consistently across the voltage operations.
> No functional changes are introduced - the validation logic remains
> identical to the original inline checks.
>
Hello maintainers,
Just a gentle ping.
Do you have any thoughts or feedback on this approach, or are these
changes even irrelevant?
I'm happy to respond to any comments or prepare a new version if needed.
Thank you for your time and for reviewing this patch.
--
Regards,
Artem