Re: [PATCH v4 1/4] scripts: ver_linux: expand and fix list

[Jonathan Corbet]

Manuel Ebner <manuelebner@xxxxxxxxxx> writes:

> It is a pain in the ass to compare the software versions on the running
> system (scripts/ver_linux) with the minimal required versions.
> Sorting both lists the same way makes side-by-side comparisons a simple task.

OK, we're getting a lot closer.  But the above text has nothing to do
with what this patch does - there is no sorting here.  What you are
doing is making the names of the tools consistent and adding those that
are missing; that's what your changelog should say.

> fix path to changes.rst
>
> make toolnames uniform with the toolnames in Changes.rst
> make version commands uniform with Changes.rst
>
> Add missing tools in ver_linux
>  bash, bc, bindgen, btrfs-progs, Clang, gdb,  GNU awk, GNU tar,
>  GRUB, GRUB2, gtags, iptables, kmod, mcelog, mkimage, openssl,
>  pahole, Python, Rust, Sphinx, squashfs-tools
>
> Signed-off-by: Manuel Ebner <manuelebner@xxxxxxxxxx>
> ---
>  scripts/ver_linux | 50 ++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 36 insertions(+), 14 deletions(-)

Otherwise I think the patch is good.  If this were the only issue, I
would just apply the patch and fix the changelog myself.

Thanks,

jon