Re: [PATCH 1/4] block: make queue_sysfs_entry instances const
From: John Garry
Date: Tue Mar 17 2026 - 12:24:29 EST
On 16/03/2026 22:43, Thomas Weißschuh wrote:
The queue_sysfs_entry structures are never modified, mark them as const.
Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
---
FWIW,
Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>
-static umode_t queue_attr_visible(struct kobject *kobj, struct attribute *attr,
+static umode_t queue_attr_visible(struct kobject *kobj, const struct attribute *attr,
int n)
This now spills over 80 characters, I am not sure what the block policy is on this (but I generally try to keep to it).