Re: [PATCH] cxl/acpi: Fix coding style issues in acpi.c

[Jonathan Cameron]

On Tue, 17 Mar 2026 07:48:17 -0700
Dave Jiang <dave.jiang@xxxxxxxxx> wrote:

> On 3/17/26 5:13 AM, Teshan Kannangara wrote:
> > Fix various coding style issues in drivers/cxl/acpi.c, including
> > indentation, line wrapping, macro alignment, cast formatting,
> > and conditional braces.  
> 
> Hi Teshan,
> Thank you for the code changes. While we appreciate it, I'm going to NAK the changes. For this sub-system, we are not going to make style changes or fixes unless it's part of functional code changes or refactor. The reason is to not introduce unnecessary churns to the code that can make fix backports difficult later on. Thanks.
> 
> DJ

I'm going to give it a quick review on the first item at least.

> 
> > 
> > No functional changes.
> > 
> > Signed-off-by: Teshan Kannangara <tpk.teshan@xxxxxxxxx>
> > ---
> >  drivers/cxl/acpi.c | 26 +++++++++++++++++---------
> >  1 file changed, 17 insertions(+), 9 deletions(-)
> > 
> > diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
> > index 127537628817..b54b962cf973 100644
> > --- a/drivers/cxl/acpi.c
> > +++ b/drivers/cxl/acpi.c
> > @@ -395,9 +395,16 @@ static void cxl_setup_extended_linear_cache(struct cxl_root_decoder *cxlrd)
> >  	cxlrd->cache_size = cache_size;
> >  }
> >  
> > -DEFINE_FREE(put_cxlrd, struct cxl_root_decoder *,
> > -	    if (!IS_ERR_OR_NULL(_T)) put_device(&_T->cxlsd.cxld.dev))
> > -DEFINE_FREE(del_cxl_resource, struct resource *, if (_T) del_cxl_resource(_T))
> > +DEFINE_FREE
> > +(put_cxlrd, struct cxl_root_decoder *,
> > +if (!IS_ERR_OR_NULL(_T))
> > +	put_device(&_T->cxlsd.cxld.dev))
> > +
> > +DEFINE_FREE
> > +(del_cxl_resource, struct resource *,
> > +if (_T)
> > +	del_cxl_resource(_T))
> > +
Why? the original code was the standard way to format these and
there is no explanation of the change in the commit message.
Is it because it's over 80 chars long?  That is guidance only and
if readability is hurt (like here) feel free to go up to 100 chars
before worrying about it.