Re: [PATCH v6 33/34] gpu: nova-core: Hopper/Blackwell: new location for PCI config mirror

From: John Hubbard

Date: Tue Mar 17 2026 - 18:17:37 EST


On 3/17/26 1:27 AM, Alexandre Courbot wrote:
> On Tue Mar 10, 2026 at 11:11 AM JST, John Hubbard wrote:
...
>> @@ -35,7 +44,10 @@ pub(crate) fn init<'a>(dev: &'a pci::Device<device::Bound>) -> impl Init<Self, E
>> // Using TASK_SIZE in r535_gsp_rpc_set_system_info() seems wrong because
>> // TASK_SIZE is per-task. That's probably a design issue in GSP-RM though.
>> maxUserVa: (1 << 47) - 4096,
>> - pciConfigMirrorBase: 0x088000,
>> + pciConfigMirrorBase: match chipset.arch() {
>> + Architecture::Turing | Architecture::Ampere | Architecture::Ada => 0x088000,
>> + Architecture::Hopper | Architecture::Blackwell => 0x092000,
>> + },
>
> Can we document this in the code? I.e. is the new mirror space unavailable on chips < Hopper?

Yes, done.

Thanks for all of these review comments across the series. I have applied all
of them, and will post a v7 shortly on the very latest drm-rust-next.

thanks,
--
John Hubbard