Re: [PATCH v2] PCI: hotplug: Change return type of pci_hp_add_bridge() to void
From: Majed Alkhaleefah
Date: Tue Mar 17 2026 - 18:49:28 EST
Hello. Just wanted to ping this v2 patch. Please let me know if
there's anything I should do. Thanks!
On Tue, 24 Feb 2026 at 18:01, Majed Alkhaleefah
<majedalkhaleefah@xxxxxxxxx> wrote:
>
> The function pci_hp_add_bridge() currently returns an int error code.
> However, none of its callers actually check or store the return value,
> neither do they need to take any special action in the event of a
> failure.
>
> The execution path of pci_hp_add_bridge() already contains relevant
> error logging. Therefore, adding additional logging/error checking is
> redundant.
>
> Make pci_hp_add_bridge() a void function.
>
> Compile-tested only.
>
> Suggested-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Signed-off-by: Majed Alkhaleefah <majedalkhaleefah@xxxxxxxxx>