Re: [PATCH v3 02/12] dt-bindings: crypto: qcom,ice: Require power-domain and iface clk

From: Krzysztof Kozlowski

Date: Wed Mar 18 2026 - 03:28:00 EST


On 17/03/2026 16:13, Dmitry Baryshkov wrote:
> On Tue, Mar 17, 2026 at 02:50:41PM +0530, Harshal Dev wrote:
>> Update the DT bindings for inline-crypto engine to require the power-domain
>> and iface clock for Eliza and Milos.
>
> Again, this mostly duplicates the subject (and your last paragraph).
> Either drop it or move it there.
>
>>
>> If the 'clk_ignore_unused' flag is not passed on the kernel command line,
>> the unused 'iface' clock could be disabled by the kernel before ICE can
>> probe. This leads to unclocked ICE hardware register accces being observed
>> during ICE driver probe. On the other hand, If the 'pd_ignore_unused' flag
>> is not passed on the kernel command line, the unused UFS_PHY_GDSC power
>> domain could be disabled by the kernel before ICE probes. This results in
>> a 'stuck' clock issue being observed when ICE attempts to enable the
>> 'core' clock.
>
> What's the difference from the previous patch?

There is no, it's just completely missing the point of development cycle
and ignoring multiple of my feedbacks.

I asked to POST A PATCH targeting current RC. One patch. Current RC, not
next.

How is this supposed to be merged without the first one? How do anyone
here imagine this is supposed to work when applying to the tree?

Best regards,
Krzysztof