Re: [PATCH net-next v6 06/10] bng_en: add HW stats infra and structured ethtool ops
From: Dan Carpenter
Date: Wed Mar 18 2026 - 03:47:22 EST
Hi Bhargava,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Bhargava-Marreddy/bng_en-add-per-PF-workqueue-timer-and-slow-path-task/20260310-231948
base: net-next/main
patch link: https://lore.kernel.org/r/20260310144044.21672-7-bhargava.marreddy%40broadcom.com
patch subject: [PATCH net-next v6 06/10] bng_en: add HW stats infra and structured ethtool ops
config: arm64-randconfig-r071-20260317 (https://download.01.org/0day-ci/archive/20260318/202603180509.nOQGZrG0-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 8.5.0
smatch: v0.5.0-9004-gb810ac53
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
| Closes: https://lore.kernel.org/r/202603180509.nOQGZrG0-lkp@xxxxxxxxx/
smatch warnings:
drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c:1598 bnge_hwrm_port_qstats_ext() warn: missing error code? 'rc'
vim +/rc +1598 drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1576 rc = bnge_hwrm_req_init(bd, req_qc, HWRM_QUEUE_PRI2COS_QCFG);
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1577 if (rc)
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1578 return rc;
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1579
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1580 req_qc->flags = cpu_to_le32(QUEUE_PRI2COS_QCFG_REQ_FLAGS_IVLAN);
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1581
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1582 resp_qc = bnge_hwrm_req_hold(bd, req_qc);
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1583 rc = bnge_hwrm_req_send(bd, req_qc);
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1584 if (!rc) {
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1585 u8 *pri2cos;
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1586 int i, j;
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1587
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1588 pri2cos = &resp_qc->pri0_cos_queue_id;
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1589 for (i = 0; i < 8; i++) {
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1590 u8 queue_id = pri2cos[i];
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1591 u8 queue_idx;
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1592
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1593 /* Per port queue IDs start from 0, 10, 20, etc */
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1594 queue_idx = queue_id % 10;
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1595 if (queue_idx >= BNGE_MAX_QUEUE) {
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1596 bn->pri2cos_valid = false;
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1597 bnge_hwrm_req_drop(bd, req_qc);
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 @1598 return rc;
return -EINVAL;
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1599 }
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1600 for (j = 0; j < bd->max_q; j++) {
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1601 if (bd->q_ids[j] == queue_id)
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1602 bn->pri2cos_idx[i] = queue_idx;
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1603 }
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1604 }
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1605 bn->pri2cos_valid = true;
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1606 }
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1607 bnge_hwrm_req_drop(bd, req_qc);
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1608
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1609 return rc;
598cdbbcf8f4c1 Bhargava Marreddy 2026-03-10 1610 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki