Re: [PATCH v2 04/11] clk: qcom: gcc-sc8180x: Use retention for PCIe power domains

From: Konrad Dybcio

Date: Wed Mar 18 2026 - 05:37:34 EST


On 3/12/26 12:12 PM, Val Packett wrote:
> As the PCIe host controller driver does not yet support dealing with the
> loss of state during suspend, use retention for relevant GDSCs.
>
> This fixes the link not surviving upon resume:
>
> nvme 0002:01:00.0: Unable to change power state from D3cold to D0, device inaccessible
> nvme nvme0: controller is down; will reset: CSTS=0xffffffff, PCI_STATUS read failed (134)
> nvme 0002:01:00.0: Unable to change power state from D3cold to D0, device inaccessible
> nvme nvme0: Disabling device after reset failure: -19
>
> Fixes: 4433594bbe5d ("clk: qcom: gcc: Add global clock controller driver for SC8180x")
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> Signed-off-by: Val Packett <val@xxxxxxxxxxxx>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad