Re: [PATCH] drm/i915/gt: Check set_default_submission() before deferencing

From: Jani Nikula

Date: Wed Mar 18 2026 - 05:46:24 EST


On Wed, 18 Mar 2026, Rahul Bukte <rahul.bukte@xxxxxxxx> wrote:
> Hi,
>
> On Fri, Mar 13, 2026 at 06:34:22PM +0200, Jani Nikula wrote:
>> On Tue, 03 Feb 2026, Suraj Kandpal <suraj.kandpal@xxxxxxxxx> wrote:
>> > From: Rahul Bukte <rahul.bukte@xxxxxxxx>
>> >
>> > When the i915 driver firmware binaries are not present, the
>> > set_default_submission pointer is not set. This pointer is
>> > dereferenced during suspend anyways.
>>
>> Which kernel vesions did this happen with? Should this have had Fixes:
>> or Cc: stable?
>
> Fixes: ff44ad51ebf8 ("drm/i915: Move engine->submit_request selection to a vfunc")
> Cc: stable@xxxxxxxxxxxxxxx
>
> Suraj, you mentioned that you have commited this to din [1]. Can we add
> this fixes and cc tags to that please?
>
> [1]: https://lore.kernel.org/all/DM3PPF208195D8D000253F905FADCA379F9E36DA@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/

Tvrtko, please pick this up for drm-intel-fixes.

BR,
Jani.

--
Jani Nikula, Intel