Re: [PATCH v2] arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' from USB host nodes

[Miquel Raynal]

On 18/03/2026 at 11:40:37 +01, Gregory CLEMENT <gregory.clement@xxxxxxxxxxx> wrote:

> +Miquèl
>
> Hello Gabor,
>
> Thanks it is better,
>
>> The 'marvell,usb-misc-reg' property is present both in the EHCI and
>> in the XHCI USB host device nodes, however it is not documented. Thus
>> 'make dtbs_check' produces warnings like these:
>>
>>   /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@58000 (marvell,armada3700-xhci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
>>           from schema $id: http://devicetree.org/schemas/usb/generic-xhci.yaml
>>   /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@5e000 (marvell,armada-3700-ehci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
>>           from schema $id: http://devicetree.org/schemas/usb/generic-ehci.yaml
>>
>> Apart from the fact that the properties are not documented, those are
>> not even used by any USB host drivers. Due to this, drop the properties
>> in order to get rid of the warnings.
>>
>> Note:
>>
>> With the same name, there is a property used for the Armada 3700 USB
>> UTMI PHYs of which dt-bindings documentation has been added in commit
>> e60958699afa ("dt-bindings: phy: mvebu-utmi: add UTMI PHY bindings").
>>
>> Additionally, the property is handled by the 'phy-mvebu-a3700-utmi'
>> driver since commit cc8b7a0ae866 ("phy: add A3700 UTMI PHY driver").
>>
>> When the nodes of the UTMI PHYs has been added to the SoC dtsi by
>> commit 05d168a56fae ("arm64: dts: marvell: armada-37xx: declare USB2
>> UTMI PHYs"), the properties has been added to the USB host controller
>> nodes also. According to the commit message this was intentional,
>
> Miquel will confirm that, after speaking with him, it appears to be a
> mistake rather than an intentional act.

Indeed, I believe it is a leftover, the property should have been added
only to the PHY nodes, not the host nodes.

The sentence above should be: s/intentional/unintentional/, the commit
messages clearly states that PHY nodes were targeted, not the
host. Plus, a follow-up commit adds the missing phy properties to the
hosts, so clearly reaching this syscon through the host node directly
does not make sense and was not intended.

Once this single word fixed, you can add my

Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>

Thanks for the fix!
Miquèl