Re: [PATCH] staging: rtl8723bs: collapse duplicate goto exit conditions

[Greg KH]

On Tue, Mar 17, 2026 at 07:55:48AM -0600, Marco Antonio Solis Segura wrote:
> Combine _FAIL and RTW_RX_HANDLED cases into a single conditional,
> removing redundant branches and simplifying control flow.
> No functional changes intended.
> 
> Signed-off-by: Marco Antonio Solis Segura <mshdevv@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index 337671b1211f..20f5f8760ba0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1339,12 +1339,8 @@ static signed int validate_recv_data_frame(struct adapter *adapter, union recv_f
>  
>  	}
>  
> -	if (ret == _FAIL) {
> +	if (ret == _FAIL || ret == RTW_RX_HANDLED)
>  		goto exit;
> -	} else if (ret == RTW_RX_HANDLED) {
> -		goto exit;
> -	}
> -
>  
>  	if (!psta) {
>  		ret = _FAIL;
> -- 
> 2.53.0
> 
> 

Someone sent this _right_ before you did:
	https://lore.kernel.org/r/20260317100723.72476-1-giacomodiclerico@xxxxxxxxx

Are you all working on this together?  What project is asking you to
send patches for this driver?

thanks,

greg k-h