Re: [PATCH] Input: sentelic: fix comment typo
From: Joseph Salisbury
Date: Wed Mar 18 2026 - 12:53:23 EST
On 3/18/26 1:43 AM, Dmitry Torokhov wrote:
Hi Joseph,Thanks for the feedback, Dmitry!
On Mon, Mar 16, 2026 at 07:48:31PM -0400, Joseph Salisbury wrote:
Sorry I did not receive the original patch but even with the typo fixed
On 3/16/26 2:12 PM, Joseph Salisbury wrote:
The file contains a spelling error in a source comment (formating).I inadvertently added Fixes: and Cc: stable tags. If possible, please
Typos in comments reduce readability and make text searches less reliable
for developers and maintainers.
Replace 'formating' with 'formatting' in the affected comment. This is a
comment-only cleanup and does not change behavior.
Fixes: fc69f4a6af49 ("Input: add new driver for Sentelic Finger Sensing Pad")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Joseph Salisbury <joseph.salisbury@xxxxxxxxxx>
---
drivers/input/mouse/sentelic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/sentelic.h b/drivers/input/mouse/sentelic.h
index 02cac0e7ad63..9ba3631e3d0f 100644
--- a/drivers/input/mouse/sentelic.h
+++ b/drivers/input/mouse/sentelic.h
@@ -60,7 +60,7 @@
#define FSP_REG_SN1 (0x41)
#define FSP_REG_SN2 (0x42)
-/* Finger-sensing Pad packet formating related definitions */
+/* Finger-sensing Pad packet formatting related definitions */
/* absolute packet type */
#define FSP_PKT_TYPE_NORMAL (0x00)
remove them as they are not appropriate for fixes to misspellings in code
comments. If it's not possible to remove them, I can send a v2.
this comment needs more work to improve readability.
Thanks.
Would you like just improved readability for that line, or would you like me to add some additional info on the definitions?
How about something like this:
-/* Finger-sensing Pad packet formating related definitions */
+/* Finger Sensing Pad packet format definitions.
+ * Define packet types and bit fields used to decode device reports.
+ */
If that looks good, I'll send a v2.