Re: [PATCH v2] rust: sync: completion: mark inline complete_all and wait_for_completion

[Boqun Feng]

On Mon, Mar 16, 2026 at 03:16:50PM +0000, Gary Guo wrote:
> On Mon Mar 16, 2026 at 3:10 PM GMT, Fabricio Parra wrote:
> > When building the kernel using the llvm-22.1.0-rust-1.93.1-x86_64
> > toolchain provided by kernel.org with ARCH=x86_64, the following symbols
> > are generated:
> > 
> > $ nm vmlinux | grep ' _R'.*Completion | rustfilt
> > ffffffff81827930 T <kernel::sync::completion::Completion>::complete_all
> > ffffffff81827950 T <kernel::sync::completion::Completion>::wait_for_completion
> > 
> > These Rust methods are thin wrappers around the C completion helpers
> > `complete_all` and `wait_for_completion`. Mark them `#[inline]` to keep
> > the wrapper pattern consistent with other small Rust helper methods.
> > 
> > After applying this patch, the above command will produce no output.
> > 
> > Link: https://github.com/Rust-for-Linux/linux/issues/1145
> > Suggested-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> > Signed-off-by: Fabricio Parra <a@xxxxxxxxxx>
> 
> Reviewed-by: Gary Guo <gary@xxxxxxxxxxx>
> 

Queued in rust-sync, thank you!

Regards,
Boqun

> > ---
> > v2:
> >   - Fixed malformed email header (RFC 5322) in the From line.
> > 
> >  rust/kernel/sync/completion.rs | 2 ++
> >  1 file changed, 2 insertions(+)
>