Re: [PATCH 2/2] media: dt-bindings: Drop redundant endpoint properties

[Laurent Pinchart]

On Mon, Mar 16, 2026 at 07:08:01PM +0100, Krzysztof Kozlowski wrote:
> On 16/03/2026 14:45, Krzysztof Kozlowski wrote:
> > The "endpoint" node references video-interfaces.yaml schema with
> > "unevaluatedProperties: false" which means that all properties from
> > referenced schema apply.  Listing some of them with ": true" is simply
> > redundant and does not make this code easier to read.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/media/marvell,mmp2-ccic.yaml        | 6 ------
> >  Documentation/devicetree/bindings/media/renesas,ceu.yaml    | 3 ---
> >  .../devicetree/bindings/media/renesas,rzg2l-cru.yaml        | 6 ------
> >  3 files changed, 15 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > index de3e483f146a..a8bf06108158 100644
> > --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > @@ -35,12 +35,6 @@ properties:
> >          $ref: video-interfaces.yaml#
> >          unevaluatedProperties: false
> >  
> > -        properties:
> > -          hsync-active: true
> > -          vsync-active: true
> > -          pclk-sample: true
> > -          bus-type: true
> > -
> >    clocks:
> >      minItems: 1
> >      items:
> > diff --git a/Documentation/devicetree/bindings/media/renesas,ceu.yaml b/Documentation/devicetree/bindings/media/renesas,ceu.yaml
> > index d527fc42c3fd..5f78c77b10a3 100644
> > --- a/Documentation/devicetree/bindings/media/renesas,ceu.yaml
> > +++ b/Documentation/devicetree/bindings/media/renesas,ceu.yaml
> > @@ -43,9 +43,6 @@ properties:
> >          unevaluatedProperties: false
> >  
> >          properties:
> > -          hsync-active: true
> > -          vsync-active: true
> > -          field-even-active: false
> 
> Removed too much, this must stay.

Disabling properties not relevant for a device doesn't scale. You would
need to disable way more than that one here. The better option is to use
"additionalProperties: false" and list the allowed properties.

> 
> >            bus-width:
> >              enum: [8, 16]

-- 
Regards,

Laurent Pinchart