Re: [PATCH 1/2] dt-bindings: hwmon: pmbus: mpq8785: add mpm3695-20 and mpm3690s-15 support

[Guenter Roeck]

On 3/18/26 02:47, Yuxi Wang wrote:
> Add device type support for mpm3695-20 and mpm3690s-15.
>
> Signed-off-by: Yuxi Wang <Yuxi.Wang@xxxxxxxxxxxxxxxxxxx>
> ---
>   Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> index 90970a0433e9..86e979cf0a00 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> @@ -19,6 +19,8 @@ properties:
>         - mps,mpm3695-25
>         - mps,mpm82504
>         - mps,mpq8785
> +      - mps,mpm3695-20

Alphabetic order, please.

We already have mps,mpm3695 and mps,mpm3695-25. The -20 model is covered by
mps,mpm3695, and a separate entry should therefore not be needed.

> +      - mps,mpm3690s-15

Unless there are other differences, that seems to be register compatible
to mps,mpm3695 and should therefore also not need a separate property entry.
It should instead be listed as compatible to mps,mpm3695.

Thanks,
Guenter