Re: [PATCH v10 10/30] KVM: arm64: Rename sve_state_reg_region

[Jean-Philippe Brucker]

On Fri, Mar 06, 2026 at 05:01:02PM +0000, Mark Brown wrote:
> As for SVE we will need to pull parts of dynamically sized registers out of
> a block of memory for SME so we will use a similar code pattern for this.
> Rename the current struct sve_state_reg_region in preparation for this.
> 
> No functional change.
> 
> Reviewed-by: Fuad Tabba <tabba@xxxxxxxxxx>
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>

Reviewed-by: Jean-Philippe Brucker <jpb@xxxxxxxxxx>

> ---
>  arch/arm64/kvm/guest.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c
> index d15aa2da1891..8c3405b5d7b1 100644
> --- a/arch/arm64/kvm/guest.c
> +++ b/arch/arm64/kvm/guest.c
> @@ -404,9 +404,9 @@ static int set_sve_vls(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg)
>   */
>  #define vcpu_sve_slices(vcpu) 1
>  
> -/* Bounds of a single SVE register slice within vcpu->arch.sve_state */
> -struct sve_state_reg_region {
> -	unsigned int koffset;	/* offset into sve_state in kernel memory */
> +/* Bounds of a single register slice within vcpu->arch.s[mv]e_state */
> +struct vec_state_reg_region {
> +	unsigned int koffset;	/* offset into s[mv]e_state in kernel memory */
>  	unsigned int klen;	/* length in kernel memory */
>  	unsigned int upad;	/* extra trailing padding in user memory */
>  };
> @@ -415,7 +415,7 @@ struct sve_state_reg_region {
>   * Validate SVE register ID and get sanitised bounds for user/kernel SVE
>   * register copy
>   */
> -static int sve_reg_to_region(struct sve_state_reg_region *region,
> +static int sve_reg_to_region(struct vec_state_reg_region *region,
>  			     struct kvm_vcpu *vcpu,
>  			     const struct kvm_one_reg *reg)
>  {
> @@ -485,7 +485,7 @@ static int sve_reg_to_region(struct sve_state_reg_region *region,
>  static int get_sve_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg)
>  {
>  	int ret;
> -	struct sve_state_reg_region region;
> +	struct vec_state_reg_region region;
>  	char __user *uptr = (char __user *)reg->addr;
>  
>  	/* Handle the KVM_REG_ARM64_SVE_VLS pseudo-reg as a special case: */
> @@ -511,7 +511,7 @@ static int get_sve_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg)
>  static int set_sve_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg)
>  {
>  	int ret;
> -	struct sve_state_reg_region region;
> +	struct vec_state_reg_region region;
>  	const char __user *uptr = (const char __user *)reg->addr;
>  
>  	/* Handle the KVM_REG_ARM64_SVE_VLS pseudo-reg as a special case: */
> 
> -- 
> 2.47.3
> 
>