Re: [PATCH v7 27/31] gpu: nova-core: Hopper/Blackwell: larger WPR2 (GSP) heap

[John Hubbard]

On 3/18/26 9:12 AM, kernel test robot wrote:
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202603181742.8HLcTchk-lkp@xxxxxxxxx/

OK, some rustfmtcheck failures. This has revealed a major gap in my
build flow: although I have rustfmt(1) set up to run upon saving
files in my code editor, not all of my scripts run it.

The code saving approach worked so well that I completely forgot
about "make rustfmt" and "make rustfmtcheck". So now those are
part of all scripts and testing here.

Both issues (this one in gsp/fw.rs, and the one in gsp/boot.rs
reported against patch 31/31) are fixed in v8.

Sorry about the failures.

thanks,
-- 
John Hubbard

> 
> All errors (new ones prefixed by >>):
> 
>    PATH=/opt/cross/clang-20/bin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
>    INFO PATH=/opt/cross/rustc-1.88.0-bindgen-0.72.1/cargo/bin:/opt/cross/clang-20/bin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
>    /usr/bin/timeout -k 100 12h /usr/bin/make KCFLAGS=\ -fno-crash-diagnostics\ -Wno-error=return-type\ -Wreturn-type\ -funsigned-char\ -Wundef\ -falign-functions=64 W=1 --keep-going LLVM=1 -j32 -C source O=/kbuild/obj/consumer/x86_64-rhel-9.4-rust ARCH=x86_64 SHELL=/bin/bash rustfmtcheck 
>    make: Entering directory '/kbuild/src/consumer'
>    make[1]: Entering directory '/kbuild/obj/consumer/x86_64-rhel-9.4-rust'
>>> Diff in drivers/gpu/nova-core/gsp/fw.rs:139:
>         fn base_rm_size(chipset: Chipset) -> u64 {
>             use crate::gpu::Architecture;
>             match chipset.arch() {
>    -            Architecture::Hopper | Architecture::Blackwell => {
>    -                GSP_FW_HEAP_PARAM_BASE_RM_SIZE_GH100
>    -            }
>    +            Architecture::Hopper | Architecture::Blackwell => GSP_FW_HEAP_PARAM_BASE_RM_SIZE_GH100,
>                 _ => u64::from(bindings::GSP_FW_HEAP_PARAM_BASE_RM_SIZE_TU10X),
>             }
>         }
>>> Diff in drivers/gpu/nova-core/gsp/fw.rs:139:
>         fn base_rm_size(chipset: Chipset) -> u64 {
>             use crate::gpu::Architecture;
>             match chipset.arch() {
>    -            Architecture::Hopper | Architecture::Blackwell => {
>    -                GSP_FW_HEAP_PARAM_BASE_RM_SIZE_GH100
>    -            }
>    +            Architecture::Hopper | Architecture::Blackwell => GSP_FW_HEAP_PARAM_BASE_RM_SIZE_GH100,
>                 _ => u64::from(bindings::GSP_FW_HEAP_PARAM_BASE_RM_SIZE_TU10X),
>             }
>         }
>>> Diff in drivers/gpu/nova-core/gsp/fw.rs:139:
>         fn base_rm_size(chipset: Chipset) -> u64 {
>             use crate::gpu::Architecture;
>             match chipset.arch() {
>    -            Architecture::Hopper | Architecture::Blackwell => {
>    -                GSP_FW_HEAP_PARAM_BASE_RM_SIZE_GH100
>    -            }
>    +            Architecture::Hopper | Architecture::Blackwell => GSP_FW_HEAP_PARAM_BASE_RM_SIZE_GH100,
>                 _ => u64::from(bindings::GSP_FW_HEAP_PARAM_BASE_RM_SIZE_TU10X),
>             }
>         }
>    make[2]: *** [Makefile:1916: rustfmt] Error 123
>    make[2]: Target 'rustfmtcheck' not remade because of errors.
>    make[1]: Leaving directory '/kbuild/obj/consumer/x86_64-rhel-9.4-rust'
>    make[1]: *** [Makefile:248: __sub-make] Error 2
>    make[1]: Target 'rustfmtcheck' not remade because of errors.
>    make: *** [Makefile:248: __sub-make] Error 2
>    make: Target 'rustfmtcheck' not remade because of errors.
>    make: Leaving directory '/kbuild/src/consumer'
>