Re: [PATCH v2 1/1] ACPI: processor: idle: Replace strlcat() with better alternative

[Rafael J. Wysocki]

On Tue, Mar 17, 2026 at 9:02 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> strlcpy() and strlcat() are confusing APIs and the former one already gone
> from the kernel. In preparation to kill strlcat() replace it with the better
> alternative.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>
> v2: moved to scnprintf() to avoid GCC warning (clang was and is okay)
>
>  drivers/acpi/processor_idle.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index 45b5d17443cf..479995a4c48a 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -1010,9 +1010,7 @@ static bool combine_lpi_states(struct acpi_lpi_state *local,
>         result->arch_flags = parent->arch_flags;
>         result->index = parent->index;
>
> -       strscpy(result->desc, local->desc, ACPI_CX_DESC_LEN);
> -       strlcat(result->desc, "+", ACPI_CX_DESC_LEN);
> -       strlcat(result->desc, parent->desc, ACPI_CX_DESC_LEN);
> +       scnprintf(result->desc, ACPI_CX_DESC_LEN, "%s+%s", local->desc, parent->desc);
>         return true;
>  }
>
> --

Applied as 7.1 material, thanks!