Re: [net-next,v8,2/4] net: phy: realtek: add RTL8224 pair order support

From: Damien Dejean

Date: Wed Mar 18 2026 - 17:58:44 EST


Le mer. 18 mars 2026 à 03:12, Jakub Kicinski <kuba@xxxxxxxxxx> a écrit :
>
> This causes rtl8224_config_init() to return -ENOSYS, which then propagates
> through phy_init_hw(), failing RTL8224 PHY initialization on non-OF kernel
> configurations.
>
> REALTEK_PHY has no 'depends on OF' in its Kconfig, so CONFIG_OF=n is a valid
> build configuration. Before this patch, RTL8224 had no config_init callback,
> so this is a new failure path.
>
> Could the code handle -ENOSYS in addition to -EINVAL, or use
> device_property_read_u32() which is firmware-agnostic?

Thanks for the feedback, I handled ENOSYS next to EINVAL in the v9 series.

Regards,
Damien