Re: [PATCH net-next v7 4/5] net: stmmac: Add PCI driver support for BCM8958x

[Jitendra Vegiraju]

Hi Russell,
On Mon, Mar 16, 2026 at 1:34 PM Jitendra Vegiraju
<jitendra.vegiraju@xxxxxxxxxxxx> wrote:
>
> On Fri, Mar 13, 2026 at 4:01 PM Russell King (Oracle)
> <linux@xxxxxxxxxxxxxxx> wrote:
> >
> > > +
> > > +     plat->suspend           = stmmac_pci_plat_suspend;
> > > +     plat->resume            = brcm_pci_resume;
> > > +     plat->bsp_priv = brcm_priv;
> >
> > Populating suspend/resume means that plat->init and plat->exit
> > will only be called on driver probe (former), probe failure (latter)
> > or remove (latter). Please consider using these to ensure that
> > all appropriate resources are properly cleaned up in all cases.
> >
>
> Thanks for pointing this out. I will check resource cleanup more closely.
After reviewing the need for  plat->init and plat-exit, I don't think we need
these handlers as this driver with fixed-link doesn't need to restore any device
specific state such as clocks.
>
> > Thanks.
> >
> > --
> > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature