Re: [PATCH 04/14] sunrpc: rename cache_pipe_upcall() to cache_do_upcall()

[Chuck Lever]

On 3/16/26 11:14 AM, Jeff Layton wrote:
> ...since it will also handle netlink upcalls.
> 
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
>  net/sunrpc/cache.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
> index 5e36f6404400aea5700d0893c00b6d69c1ec128e..7081b6e0e9090d2ba7da68c1f36b4c170fb228cb 100644
> --- a/net/sunrpc/cache.c
> +++ b/net/sunrpc/cache.c
> @@ -1206,7 +1206,7 @@ static bool cache_listeners_exist(struct cache_detail *detail)
>   *
>   * Each request is at most one page long.
>   */
> -static int cache_pipe_upcall(struct cache_detail *detail, struct cache_head *h)
> +static int cache_do_upcall(struct cache_detail *detail, struct cache_head *h)
>  {
>  	char *buf;
>  	struct cache_request *crq;

Nit: The block comment just above still reads "queue it up for read() by
the upcall daemon", which is will be made stale (or at least a little
misleading) later in the series.


> @@ -1251,7 +1251,7 @@ int sunrpc_cache_upcall(struct cache_detail *detail, struct cache_head *h)
>  {
>  	if (test_and_set_bit(CACHE_PENDING, &h->flags))
>  		return 0;
> -	return cache_pipe_upcall(detail, h);
> +	return cache_do_upcall(detail, h);
>  }
>  EXPORT_SYMBOL_GPL(sunrpc_cache_upcall);
>  
> 


-- 
Chuck Lever