Re: [PATCH v3 2/3] arm64: dts: qcom: Introduce Eliza Soc base dtsi

[Abel Vesa]

On 26-03-18 12:18:09, Konrad Dybcio wrote:
> On 3/18/26 11:19 AM, Abel Vesa wrote:
> > Introduce the initial support for the Qualcomm Eliza SoC. It comes in
> > different flavors. There is SM7750 for mobiles and then QC7790S/M for IoT.
> > Describe the common parts under a common dtsi.
> > 
> > The initial submission enables support for:
> > - CPU nodes with cpufreq and cpuidle support
> > - Global Clock Controller (GCC)
> > - Resource State Coordinator (RSC) with clock controller & genpd provider
> > - Interrupt controller
> > - Power Domain Controller (PDC)
> > - Vendor specific SMMU
> > - SPMI bus arbiter
> > - Top Control and Status Register (TCSR)
> > - Top Level Mode Multiplexer (TLMM)
> > - Debug UART
> > - Reserved memory nodes
> > - Interconnect providers
> > - System timer
> > - UFS
> > 
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> > ---
> 
> [...]
> 
> > +		gcc: clock-controller@100000 {
> > +			compatible = "qcom,eliza-gcc";
> > +			reg = <0x0 0x00100000 0x0 0x1f4200>;
> > +
> > +			clocks = <&bi_tcxo_div2>,
> > +				 <&sleep_clk>,
> > +				 <0>,
> > +				 <0>,
> > +				 <&ufs_mem_phy 0>,
> > +				 <&ufs_mem_phy 1>,
> > +				 <&ufs_mem_phy 2>,
> > +				 <0>;
> 
> power-domains = <&rpmhpd RPMHPD_CX>;

Bjorn has already applied this version.

I'll send a fix soon where I'll be addressing all the other comments you
had bellow.

Thanks for reviewing.