Re: [PATCH net-next v2] bonding: remove bonding_priv.h
From: Simon Horman
Date: Thu Mar 19 2026 - 13:47:43 EST
On Wed, Mar 18, 2026 at 05:22:48AM -0700, Breno Leitao wrote:
> bonding_priv.h only defined DRV_NAME and DRV_DESCRIPTION, but caused
> unnecessary recompilation: it included <generated/utsrelease.h> to
> define bond_version, which is used solely in bond_procfs.c. With
> CONFIG_LOCALVERSION_AUTO=y, utsrelease.h is regenerated on every git
> commit, so any git operation triggered recompilation of bond_main.c
> which also included bonding_priv.h.
>
> Remove the header entirely, as suggested by Jakub, given the macros on
> this file can be integrated into the C files directly.
>
> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>
> ---
> Changes in v2:
> - Remove drivers/net/bonding/bonding_priv.h completly (Jakub)
> - Link to v1: https://patch.msgid.link/20260316-bond_uts-v1-1-428696ea79d5@xxxxxxxxxx
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>