[PATCH v1 2/3] soundwire: increase group->max_size after allocation
From: Baoli.Zhang
Date: Fri Mar 20 2026 - 01:42:34 EST
Only update `group->max_size` after both allocations succeed to avoid
leaving the group's state inconsistent if one allocation fails.
Signed-off-by: Baoli.Zhang <baoli.zhang@xxxxxxxxxxxxxxx>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
drivers/soundwire/generic_bandwidth_allocation.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/soundwire/generic_bandwidth_allocation.c b/drivers/soundwire/generic_bandwidth_allocation.c
index f016ad088a1db..cd9ccbaf0e46f 100644
--- a/drivers/soundwire/generic_bandwidth_allocation.c
+++ b/drivers/soundwire/generic_bandwidth_allocation.c
@@ -308,9 +308,8 @@ static int sdw_add_element_group_count(struct sdw_group *group,
unsigned int *rates;
unsigned int *lanes;
- group->max_size += 1;
rates = krealloc(group->rates,
- (sizeof(int) * group->max_size),
+ sizeof(int) * (group->max_size + 1),
GFP_KERNEL);
if (!rates)
return -ENOMEM;
@@ -318,12 +317,14 @@ static int sdw_add_element_group_count(struct sdw_group *group,
group->rates = rates;
lanes = krealloc(group->lanes,
- (sizeof(int) * group->max_size),
+ sizeof(int) * (group->max_size + 1),
GFP_KERNEL);
if (!lanes)
return -ENOMEM;
group->lanes = lanes;
+
+ group->max_size += 1;
}
group->rates[group->count] = rate;
--
2.43.0